Skip to content

Feat/enable native decimal support #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Feat/enable native decimal support #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef81829
feat: enable native Arrow decimal type support in ScanRow
nikhilmehta16 Aug 1, 2025
2206e58
test: update test expectations for native decimal support
nikhilmehta16 Aug 1, 2025
c936cea
cleanup: remove commented code
nikhilmehta16 Aug 1, 2025
ef93826
enabled UseArrowNativeDecimal by default
nikhilmehta16 Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,7 @@ func (ucfg ArrowConfig) WithDefaults() ArrowConfig {
ucfg.UseArrowBatches = true
ucfg.UseArrowNativeTimestamp = true
ucfg.UseArrowNativeComplexTypes = true
ucfg.UseArrowNativeDecimal = true

return ucfg
}
Expand Down
6 changes: 3 additions & 3 deletions internal/rows/arrowbased/arrowRows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,9 @@ func (ars *arrowRowScanner) ScanRow(
col := ars.colInfo[i]
dbType := col.dbType

if (dbType == cli_service.TTypeId_DECIMAL_TYPE && ars.UseArrowNativeDecimal) ||
(isIntervalType(dbType) && ars.UseArrowNativeIntervalTypes) {
// not yet fully supported
// Only block interval types, allow decimals to proceed
if isIntervalType(dbType) && ars.UseArrowNativeIntervalTypes {
// interval types are not yet fully supported
ars.Error().Msgf(errArrowRowsUnsupportedNativeType(dbType.String()))
return dbsqlerrint.NewDriverError(ars.ctx, errArrowRowsUnsupportedNativeType(dbType.String()), nil)
}
Expand Down
2 changes: 1 addition & 1 deletion internal/rows/arrowbased/arrowRows_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,7 @@ func TestArrowRowScanner(t *testing.T) {

err := ars.ScanRow(dest, 0)

if i < 3 {
if i < 4 {
Copy link
Contributor

@shivam2680 shivam2680 Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a separate test to verify changes in ScanRow? That tests ScanRow no longer blocks decimal types

assert.Nil(t, err)
} else {
assert.NotNil(t, err)
Expand Down