Give warning for deprecated clientId param #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivam2680
requested review from
andrefurlan-db,
benc-db,
jackyhu-db,
rcypher-databricks,
superdupershant and
yunbodeng-db
as code owners
shivam2680
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
jackyhu-db
reviewed
Feb 21, 2025
| 'Warning: The "clientId" option is deprecated. Please use "userAgentEntry" instead.', | ||
| ); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
can we assign it to userAgentEntry if it only give the warning.
Contributor
Author
There was a problem hiding this comment.
We can,
but the issue of sensitive info being passed through this param will persist.
Collaborator
There was a problem hiding this comment.
can you try to redact it if it is service principal client id
jackyhu-db
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added check in connect call to see if clientId is passed and raise warning to use userAgentEntry
Testing
Unit test added