Add metric view metadata support #312
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for metric view metadata in the Databricks SQL Node.js driver, following the JDBC driver implementation.
Changes
enableMetricViewMetadataoptional boolean toConnectionOptionsinterfaceenableMetricViewMetadataoptional boolean toClientConfiginterfaceDBSQLClient.connect()to store the configurationDBSQLClient.openSession()to injectspark.sql.thriftserver.metadata.metricview.enabled=truewhen enabledBehavior
When
enableMetricViewMetadata=true:getTables()andgetTableTypes()will include METRIC_VIEW entriesgetColumns()will return measure columns with<data_type> measureformat in TYPE_NAMEUsage
Testing
All 437 unit tests pass including 6 new tests for this feature.
Backward Compatibility
Feature is disabled by default - fully backward compatible.