Skip to content

Commit 785d12c

Browse files
committed
remove unused logs
Signed-off-by: Nikhil Suri <[email protected]>
1 parent b005890 commit 785d12c

File tree

3 files changed

+13
-79
lines changed

3 files changed

+13
-79
lines changed

src/databricks/sql/client.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -320,9 +320,7 @@ def read(self) -> Optional[OAuthToken]:
320320
)
321321

322322
self.force_enable_telemetry = kwargs.get("force_enable_telemetry", False)
323-
self.enable_telemetry = kwargs.get(
324-
"enable_telemetry", True
325-
) # Default to True for telemetry
323+
self.enable_telemetry = kwargs.get("enable_telemetry", False)
326324
self.telemetry_enabled = TelemetryHelper.is_telemetry_enabled(self)
327325

328326
TelemetryClientFactory.initialize_telemetry_client(

src/databricks/sql/common/feature_flag.py

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -106,48 +106,28 @@ def get_flag_value(self, name: str, default_value: Any) -> Any:
106106

107107
def _refresh_flags(self):
108108
"""Performs a synchronous network request to fetch and update flags."""
109-
import logging
110-
111-
logger = logging.getLogger(__name__)
112-
113109
headers = {}
114110
try:
115111
# Authenticate the request
116112
self._connection.session.auth_provider.add_headers(headers)
117113
headers["User-Agent"] = self._connection.session.useragent_header
118114

119-
logger.info(
120-
f"Feature Flags: Sending GET request to endpoint: {self._feature_flag_endpoint}"
121-
)
122115
response = self._http_client.request(
123116
HttpMethod.GET, self._feature_flag_endpoint, headers=headers, timeout=30
124117
)
125118

126-
logger.info(f"Feature Flags: HTTP Response status code: {response.status}")
127-
128119
if response.status == 200:
129120
# Parse JSON response from urllib3 response data
130121
response_data = json.loads(response.data.decode())
131-
logger.info(
132-
f"Feature Flags: ✓ SUCCESS - Received {len(response_data.get('flags', []))} flags from server"
133-
)
134-
logger.info(f"Feature Flags: Response data: {response_data}")
135122
ff_response = FeatureFlagsResponse.from_dict(response_data)
136123
self._update_cache_from_response(ff_response)
137-
logger.info(f"Feature Flags: Loaded into cache: {self._flags}")
138124
else:
139125
# On failure, initialize with an empty dictionary to prevent re-blocking.
140-
logger.info(
141-
f"Feature Flags: ✗ FAILED - Non-200 status code {response.status}, using empty flags"
142-
)
143126
if self._flags is None:
144127
self._flags = {}
145128

146129
except Exception as e:
147130
# On exception, initialize with an empty dictionary to prevent re-blocking.
148-
logger.info(
149-
f"Feature Flags: ✗ EXCEPTION - {type(e).__name__}: {e}, using empty flags"
150-
)
151131
if self._flags is None:
152132
self._flags = {}
153133

src/databricks/sql/telemetry/telemetry_client.py

Lines changed: 12 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -110,48 +110,15 @@ def get_auth_flow(auth_provider):
110110
@staticmethod
111111
def is_telemetry_enabled(connection: "Connection") -> bool:
112112
if connection.force_enable_telemetry:
113-
logger.info("Telemetry: force_enable_telemetry=True, telemetry ENABLED")
114113
return True
115114

116115
if connection.enable_telemetry:
117-
from databricks.sql import __version__
118-
119-
endpoint = f"https://{connection.session.host}/api/2.0/connector-service/feature-flags/PYTHON/{__version__}"
120-
logger.info(
121-
f"Telemetry: enable_telemetry=True, checking server-side feature flag"
122-
)
123-
logger.info(f"Telemetry: Feature flag endpoint: {endpoint}")
124-
logger.info(
125-
f"Telemetry: Looking for flag: {TelemetryHelper.TELEMETRY_FEATURE_FLAG_NAME}"
116+
context = FeatureFlagsContextFactory.get_instance(connection)
117+
flag_value = context.get_flag_value(
118+
TelemetryHelper.TELEMETRY_FEATURE_FLAG_NAME, default_value=False
126119
)
127-
128-
try:
129-
context = FeatureFlagsContextFactory.get_instance(connection)
130-
flag_value = context.get_flag_value(
131-
TelemetryHelper.TELEMETRY_FEATURE_FLAG_NAME, default_value=False
132-
)
133-
logger.info(
134-
f"Telemetry: Feature flag fetch SUCCESS - received value: '{flag_value}'"
135-
)
136-
137-
enabled = str(flag_value).lower() == "true"
138-
if enabled:
139-
logger.info(
140-
f"Telemetry: ✓ Server flag is 'true', telemetry ENABLED"
141-
)
142-
else:
143-
logger.info(
144-
f"Telemetry: ✗ Server flag is '{flag_value}' (not 'true'), telemetry DISABLED"
145-
)
146-
return enabled
147-
except Exception as e:
148-
logger.info(
149-
f"Telemetry: Feature flag fetch FAILED with exception: {type(e).__name__}: {e}"
150-
)
151-
logger.info("Telemetry: Defaulting to DISABLED due to fetch failure")
152-
return False
120+
return str(flag_value).lower() == "true"
153121
else:
154-
logger.info("Telemetry: enable_telemetry=False, telemetry DISABLED")
155122
return False
156123

157124

@@ -224,14 +191,13 @@ def __init__(
224191

225192
def _export_event(self, event):
226193
"""Add an event to the batch queue and flush if batch is full"""
227-
logger.info(f"Exporting telemetry event for connection {self._session_id_hex}")
194+
logger.debug("Exporting event for connection %s", self._session_id_hex)
228195
with self._lock:
229196
self._events_batch.append(event)
230-
logger.info(
231-
f"Event added to batch, batch size now: {len(self._events_batch)}/{self._batch_size}"
232-
)
233197
if len(self._events_batch) >= self._batch_size:
234-
logger.info(f"Batch size reached ({self._batch_size}), flushing events")
198+
logger.debug(
199+
"Batch size limit reached (%s), flushing events", self._batch_size
200+
)
235201
self._flush()
236202

237203
def _flush(self):
@@ -499,8 +465,9 @@ def initialize_telemetry_client(
499465
TelemetryClientFactory._initialize()
500466

501467
if session_id_hex not in TelemetryClientFactory._clients:
502-
logger.info(
503-
f"Creating telemetry client for connection {session_id_hex}, telemetry_enabled={telemetry_enabled}"
468+
logger.debug(
469+
"Creating new TelemetryClient for connection %s",
470+
session_id_hex,
504471
)
505472
if telemetry_enabled:
506473
TelemetryClientFactory._clients[
@@ -514,25 +481,14 @@ def initialize_telemetry_client(
514481
batch_size=batch_size,
515482
client_context=client_context,
516483
)
517-
logger.info(
518-
f"Created TelemetryClient for connection {session_id_hex}"
519-
)
520484
else:
521485
TelemetryClientFactory._clients[
522486
session_id_hex
523487
] = NoopTelemetryClient()
524-
logger.info(
525-
f"Created NoopTelemetryClient for connection {session_id_hex}"
526-
)
527488
except Exception as e:
528-
logger.info(
529-
f"Failed to initialize telemetry client: {type(e).__name__}: {e}"
530-
)
489+
logger.debug("Failed to initialize telemetry client: %s", e)
531490
# Fallback to NoopTelemetryClient to ensure connection doesn't fail
532491
TelemetryClientFactory._clients[session_id_hex] = NoopTelemetryClient()
533-
logger.info(
534-
f"Fallback to NoopTelemetryClient for connection {session_id_hex}"
535-
)
536492

537493
@staticmethod
538494
def get_telemetry_client(session_id_hex):

0 commit comments

Comments
 (0)