Skip to content

Testing for telemetry #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 31, 2025
Merged

Testing for telemetry #616

merged 6 commits into from
Jul 31, 2025

Conversation

@saishreeeee
Copy link
Contributor

@saishreeeee saishreeeee commented Jun 25, 2025 •
edited
Loading

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

Added multithread tests for race conditions

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Related Tickets & Documents

PECOBLR-584

@saishreeeee saishreeeee self-assigned this Jun 25, 2025
@saishreeeee saishreeeee changed the title added multithreaded tests, exeception handling tests Testing for telemetry Jun 25, 2025
vikrantpuppala
vikrantpuppala reviewed Jun 30, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jul 17, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@github-actions
Copy link

github-actions bot commented Jul 17, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@github-actions
Copy link

github-actions bot commented Jul 22, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@saishreeeee
e2e test telemetry
9f6e2e1 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee saishreeeee reopened this Jul 22, 2025
vikrantpuppala
vikrantpuppala reviewed Jul 23, 2025
View reviewed changes
@saishreeeee
assert session id, statement id
f6281fe 
Signed-off-by: Sai Shree Pradhan <[email protected]>
jprakash-db
jprakash-db reviewed Jul 28, 2025
View reviewed changes
@saishreeeee saishreeeee requested a review from jprakash-db July 29, 2025 19:58
jprakash-db
jprakash-db approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@jprakash-db jprakash-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits. Overall LGTM. Thanks for making the changes

@saishreeeee
finally block
37d7b48 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
removed setup clean up
f67af96 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
finally in test_complex_types
17696dd 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee saishreeeee merged commit fe8cd57 into main Jul 31, 2025
23 checks passed
@saishreeeee saishreeeee deleted the telemetry-testing branch August 1, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikrantpuppala vikrantpuppala vikrantpuppala approved these changes

@jprakash-db jprakash-db jprakash-db approved these changes

@samikshya-db samikshya-db Awaiting requested review from samikshya-db

Assignees

@saishreeeee saishreeeee

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saishreeeee @vikrantpuppala @jprakash-db