[WIP] Backport external table clone on top of 1.9.latest #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport (not tested) Signed-off-by: Dmitry Volodin <[email protected]>
Contributor
Author
|
@samgans please review. I am fixing the conflicts as 1.9.latest was updated |
samgans
reviewed
Sep 25, 2025
samgans
reviewed
Sep 25, 2025
Comment on lines
+14
to
+15
| DBT_DATABRICKS_HTTP_SESSION_HEADERS, | ||
| DBT_DATABRICKS_INVOCATION_ENV, |
Contributor
There was a problem hiding this comment.
Why is it there? I don't see any mentions of those in the code.
Co-authored-by: samgans <[email protected]>
mi-volodin
commented
Sep 26, 2025
Comment on lines
+3
to
+5
| from typing import Optional | ||
|
|
||
| from dbt.adapters.databricks import catalogs, constants |
Contributor
Author
There was a problem hiding this comment.
@samgans I think all the changes in this files is unrelated to your code, is that correct?
Contributor
Author
|
We put this PR on pause. The driver was broken elementary, but they've announced that they fix the compatibility with dbt-databricks soon. They've already released 0.20 with version now being non-pinned |
Contributor
Author
|
Elementary fixed the issue, so we close it as no longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of the changes introduced in #1079 and #1095.
Not everything is applied cleanly as there are some major changes between 1.9 and 1.10 in terms of metadata management and testing.
Description
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.