Skip to content

fix: Serverless Python model environment version configuration (#1277) #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benc-db merged 6 commits into from
Jan 9, 2026
Merged

fix: Serverless Python model environment version configuration (#1277) #1286

benc-db merged 6 commits into from
Jan 9, 2026

Conversation

@benc-db
Copy link
Collaborator

@benc-db benc-db commented Dec 18, 2025

Resolves #1277

Description

  • Replace deprecated 'client' field with 'environment_version' in environment spec for serverless Python models
  • Add JobEnvironment SDK object conversion in api_client.py to fix 'dict object has no attribute as_dict' error
  • Enable TestServerlessClusterWithEnvironment functional test (was previously skipped as 'not available in Databricks yet')
  • Add unit tests for environment_version usage and user-provided environments override behavior
  • Users can now specify custom environment versions via python_job_config.environments

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.

@benc-db
Fix serverless Python model environment version configuration (#1277)
f94c1b2 
- Replace deprecated 'client' field with 'environment_version' in
  environment spec for serverless Python models
- Add JobEnvironment SDK object conversion in api_client.py to fix
  'dict object has no attribute as_dict' error
- Enable TestServerlessClusterWithEnvironment functional test (was
  previously skipped as 'not available in Databricks yet')
- Add unit tests for environment_version usage and user-provided
  environments override behavior
- Users can now specify custom environment versions via
  python_job_config.environments
@benc-db benc-db requested a review from ericj-db as a code owner December 18, 2025 17:51
@benc-db benc-db changed the title Fix serverless Python model environment version configuration (#1277) fix: Serverless Python model environment version configuration (#1277) Dec 18, 2025
@benc-db benc-db requested a review from sd-db December 18, 2025 17:51
@benc-db benc-db mentioned this pull request Dec 18, 2025
Closed
@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  dbt/adapters/databricks
  api_client.py 536
  dbt/adapters/databricks/python_models
  python_submissions.py
Project Total  

This report was generated by python-coverage-comment-action

ikhudur
ikhudur reviewed Jan 3, 2026
View reviewed changes
@benc-db benc-db deployed to azure-prod January 8, 2026 21:48 — with GitHub Actions Active
@benc-db benc-db merged commit 4878f56 into main Jan 9, 2026
10 checks passed
@benc-db benc-db deleted the environment_investigation branch January 9, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericj-db ericj-db Awaiting requested review from ericj-db

@sd-db sd-db Awaiting requested review from sd-db sd-db is a code owner

1 more reviewer

@ikhudur ikhudur ikhudur left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Defining Serverless version for notebook jobs

3 participants

@benc-db @ikhudur