Skip to content

Conversation

@phi-dbq
Copy link
Contributor

@phi-dbq phi-dbq commented Aug 10, 2017

What changes are proposed in this pull request?

Add prospector for style checking, etc.

@codecov-io
Copy link

codecov-io commented Aug 10, 2017

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files          19       19           
  Lines         991      991           
  Branches        5        5           
=======================================
  Hits          843      843           
  Misses        148      148

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5a6e07...f1687a0. Read the comment docs.

@thunterdb
Copy link
Contributor

@phi-dbq thanks! Can you please document in the README (for example in running teh unit tests) that you need prospector installed with a link to the page of that tool?
Also, I am surprised it has not found anything... Are there some good rules we have not turned on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants