fix: do not attempt to delete default schema for foriegn catalogs (#2622)

* fix: do not attempt to delete default schema for foriegn catalogs

* fix: do not attempt to delete default schema for foriegn catalogs

* fix: add test for foriegn catalog create

* better comment

Co-authored-by: vuong-nguyen <[email protected]>

* fix: formatting

---------

Co-authored-by: vuong-nguyen <[email protected]>

Author: abest-tz

catalog/resource_catalog.go

@@ -64,8 +64,8 @@ func ResourceCatalog() *schema.Resource {
 			if err != nil {
 				return err
 			}
-			// only remove catalog default schema for non-Delta Sharing catalog
-			if ci.ShareName == "" {
+			// only remove catalog default schema for standard catalog (e.g. non-Delta Sharing, non-foreign)
+			if ci.ShareName == "" && ci.ConnectionName == "" {
 				if err := w.Schemas.DeleteByFullName(ctx, ci.Name+".default"); err != nil {
 					return fmt.Errorf("cannot remove new catalog default schema: %w", err)
 				}

catalog/resource_catalog_test.go

@@ -68,6 +68,59 @@ func TestCatalogCreateAlsoDeletesDefaultSchema(t *testing.T) {
 	}.ApplyNoError(t)
 }
 
+func TestCatalogCreateWithForiegnCatalogDoesNotDeleteDefaultSchema(t *testing.T) {
+	qa.ResourceFixture{
+		Fixtures: []qa.HTTPFixture{
+			{
+				Method:   "POST",
+				Resource: "/api/2.1/unity-catalog/catalogs",
+				ExpectedRequest: catalog.CreateCatalog{
+					Name:    "a",
+					Comment: "b",
+					Properties: map[string]string{
+						"c": "d",
+					},
+					ConnectionName: "g", // this indicates a foriegn catalog
+				},
+				Response: catalog.CatalogInfo{
+					Name:    "a",
+					Comment: "b",
+					Properties: map[string]string{
+						"c": "d",
+					},
+					MetastoreId:    "e",
+					Owner:          "f",
+					ConnectionName: "g",
+				},
+			},
+			{
+				Method:   "GET",
+				Resource: "/api/2.1/unity-catalog/catalogs/a?",
+				Response: catalog.CatalogInfo{
+					Name:    "a",
+					Comment: "b",
+					Properties: map[string]string{
+						"c": "d",
+					},
+					MetastoreId:    "e",
+					Owner:          "f",
+					ConnectionName: "g",
+				},
+			},
+		},
+		Resource: ResourceCatalog(),
+		Create:   true,
+		HCL: `
+		name = "a"
+		comment = "b"
+		properties = {
+			c = "d"
+		}
+		connection_name = "g"
+		`,
+	}.ApplyNoError(t)
+}
+
 func TestCatalogCreateWithOwnerAlsoDeletesDefaultSchema(t *testing.T) {
 	qa.ResourceFixture{
 		Fixtures: []qa.HTTPFixture{