Skip to content

[Fix] handle auto-enabled errors withdatabricks_system_schema#4547

Merged
alexott merged 7 commits intomainfrom
fix/system_tables
Mar 12, 2025
Merged

[Fix] handle auto-enabled errors withdatabricks_system_schema#4547
alexott merged 7 commits intomainfrom
fix/system_tables

Conversation

@nkvuong
Copy link
Copy Markdown
Contributor

@nkvuong nkvuong commented Mar 4, 2025

Changes

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@nkvuong nkvuong requested review from a team as code owners March 4, 2025 08:34
@nkvuong nkvuong requested review from hectorcast-db and removed request for a team March 4, 2025 08:34
@nkvuong nkvuong temporarily deployed to test-trigger-is March 4, 2025 08:34 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is March 4, 2025 08:35 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is March 4, 2025 13:24 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is March 4, 2025 13:24 — with GitHub Actions Inactive
@alexott
Copy link
Copy Markdown
Contributor

alexott commented Mar 4, 2025

@nkvuong how it will handle destroy? Will it fail trying to disable the schema?

@nkvuong nkvuong force-pushed the fix/system_tables branch from 16d8fc2 to 1f067fc Compare March 5, 2025 07:10
@nkvuong nkvuong temporarily deployed to test-trigger-is March 5, 2025 07:10 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is March 5, 2025 07:12 — with GitHub Actions Inactive
@nkvuong
Copy link
Copy Markdown
Contributor Author

nkvuong commented Mar 5, 2025

@nkvuong how it will handle destroy? Will it fail trying to disable the schema?

@alexott our API actually succeeds 😕

@nkvuong nkvuong temporarily deployed to test-trigger-is March 5, 2025 07:21 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is March 5, 2025 07:22 — with GitHub Actions Inactive
@alexott
Copy link
Copy Markdown
Contributor

alexott commented Mar 5, 2025

@nkvuong maybe we can add a computed flag that specifies that it's auto-enabled? And then in the Delete skip the deletion?

@nkvuong nkvuong temporarily deployed to test-trigger-is March 5, 2025 12:49 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is March 5, 2025 12:50 — with GitHub Actions Inactive
@nkvuong nkvuong requested a review from alexott March 5, 2025 12:51
@nkvuong nkvuong temporarily deployed to test-trigger-is March 5, 2025 12:55 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is March 5, 2025 12:56 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is March 11, 2025 19:07 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4547
  • Commit SHA: d127b8c8183eb483a892627d006355706e9e66be

Checks will be approved automatically on success.

@alexott alexott temporarily deployed to test-trigger-is March 11, 2025 19:09 — with GitHub Actions Inactive
@alexott alexott added this pull request to the merge queue Mar 12, 2025
Merged via the queue into main with commit 796af80 Mar 12, 2025
13 checks passed
@alexott alexott deleted the fix/system_tables branch March 12, 2025 06:40
deco-sdk-tagging bot added a commit that referenced this pull request Mar 12, 2025
## Release v1.70.0

### Bug Fixes

 * Fix creation of `databricks_storage_credential` and `databricks_credential` resources on GCP with isolation mode ([#4563](#4563))
 * Handle auto-enabled errors with `databricks_system_schema` [#4547](#4547)
 * Skip Read after Create in `databricks_secret_acl` to avoid errors([#4548](#4548)).

### Documentation

 * Document `amazon_bedrock_config.instance_profile_arn` in `databricks_model_serving` ([#4549](#4549))
 * Document management of permissions of `databricks_budget_policy` resource ([#4561](#4561))
 * Document `budget_policy_id` in `databricks_app` resource and data sources ([#4557](#4557))
 * Add a note on how `databricks_grants` work with `MANAGE` permission [#4546](#4546)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ISSUE] Failures for Auto-Enabled System Tables

2 participants