[Fix] Update databricks_mlflow_experiment resource to include tags#4569
Closed
[Fix] Update databricks_mlflow_experiment resource to include tags#4569
databricks_mlflow_experiment resource to include tags#4569Conversation
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
changed the title
databricks_mlflow_experiment resource to include tags
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
…ricks into mlflow-schema
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
approved these changes
Mar 11, 2025
Contributor
alexott
left a comment
alexott
left a comment
There was a problem hiding this comment.
in general good, just not sure that this is a fix
| ### New Features and Improvements | ||
|
|
||
| ### Bug Fixes | ||
| * [Fix] Update databricks_mlflow_experiment resource to include tags ([#4569](https://github.com/databricks/terraform-provider-databricks/pull/4569)) |
Contributor
There was a problem hiding this comment.
I would say that this "new feature" not a fix
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the databricks_mlflow_experiment resource so that it includes a tags field per the OpenAPI spec while removing the outdated description field.
- Added support for tags in the Experiment resource and corresponding tests
- Removed the description field from the resource schema
- Updated documentation and changelog to reflect the new resource structure
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mlflow/resource_mlflow_experiment_test.go | Added a new test to verify experiment creation with tags |
| NEXT_CHANGELOG.md | Updated changelog with a fix entry for the tags implementation |
| docs/resources/mlflow_experiment.md | Updated resource documentation to replace description with tags |
| mlflow/resource_mlflow_experiment.go | Modified the Experiment struct: removed description and added tags |
Comments suppressed due to low confidence (1)
mlflow/resource_mlflow_experiment_test.go:95
- Consider adding an assertion to verify that the 'tags' field in the resource state is correctly populated.
assert.Equal(t, re.Name, d.Get("name"), "Experiment name should be set")
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Contributor
|
Superseded by #4606 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This resource is outdated as it is maintained manually. PR adds the tags field which is present in OpenAPI spec and removes the description field which isn't present.
The right way to solve this is to migrate this to Go SDK however since the bandwidth is low for this quarter to include that work and this is required in CLI, adding a quick fix until this is migrated to autogeneration framework.
Tests
Added unit test
make testrun locallydocs/folderinternal/acceptance