Skip to content

[Internal] Use go tool from Go 1.24 instead of go run#4577

Merged
alexott merged 1 commit intomainfrom
internal/go-tool-use
Mar 18, 2025
Merged

[Internal] Use go tool from Go 1.24 instead of go run#4577
alexott merged 1 commit intomainfrom
internal/go-tool-use

Conversation

@alexott
Copy link
Copy Markdown
Contributor

@alexott alexott commented Mar 13, 2025

Changes

With go tool introduced in Go 1.24 it's easier to manage dependencies to tools used for tests, formatting, linting, etc.

Resolves #4343

NO_CHANGELOG=true

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

With `go tool` introduced in Go 1.24 it's easier to manage dependencies to tools used for
tests, formatting, linting, etc.

Resolves #4343

NO_CHANGELOG=true
@alexott alexott requested review from a team as code owners March 13, 2025 08:25
@alexott alexott requested review from mgyucht and removed request for a team March 13, 2025 08:25
@alexott alexott temporarily deployed to test-trigger-is March 13, 2025 08:25 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4577
  • Commit SHA: d95a1c304d47c2f5e9e2f89db1f90414a515b6cd

Checks will be approved automatically on success.

@alexott alexott temporarily deployed to test-trigger-is March 13, 2025 08:27 — with GitHub Actions Inactive
@alexott alexott requested a review from parthban-db March 13, 2025 09:15
@alexott alexott added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit f9a92fa Mar 18, 2025
12 checks passed
@alexott alexott deleted the internal/go-tool-use branch March 18, 2025 09:09
github-merge-queue bot pushed a commit to databricks/cli that referenced this pull request Apr 7, 2025
## Changes
- Bump to to 1.24.2 https://go.dev/doc/go1.24

## Why
Potentially relevant features:
 - tool section in go.mod
- Directory limited file-system access:
https://go.dev/doc/go1.24#directory-limited-filesystem-access
- new omitzero tag in encoding/json:
https://go.dev/doc/go1.24#encodingjsonpkgencodingjson

Related: Terraform provider upgraded to 1.24 in February
(databricks/terraform-provider-databricks#4508)
and made use of new "tool" functionality
(databricks/terraform-provider-databricks#4577).

## Tests
Existing tests.
micheltuu pushed a commit that referenced this pull request Sep 11, 2025
<!-- Summary of your changes that are easy to understand -->

With `go tool` introduced in Go 1.24 it's easier to manage dependencies
to tools used for tests, formatting, linting, etc.

Resolves #4343

NO_CHANGELOG=true

<!--
How is this tested? Please see the checklist below and also describe any
other relevant tests
-->

- [ ] `make test` run locally
- [ ] relevant change in `docs/` folder
- [ ] covered with integration tests in `internal/acceptance`
- [ ] using Go SDK
- [ ] using TF Plugin Framework
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Internal] Switch all tools to use via go tool after upgrading to Go 1.24

2 participants