Skip to content

[Internal] Use TEST_ENVIRONMENT_TYPE for acceptance test environment detection #5476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanmay-db merged 7 commits into from
Mar 26, 2026
Merged

[Internal] Use TEST_ENVIRONMENT_TYPE for acceptance test environment detection #5476

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3704e5b
[Internal] Update test methods to use new environment variables
tanmay-db Mar 11, 2026
b4b166b
Merge branch 'main' of github.com:databricks/terraform-provider-datab…
tanmay-db Mar 17, 2026
e62386d
Merge branch 'main' of github.com:databricks/terraform-provider-datab…
tanmay-db Mar 25, 2026
978eb44
Merge branch 'main' of github.com:databricks/terraform-provider-datab…
tanmay-db Mar 25, 2026
885fd01
Merge branch 'main' into move-away-acc-id
tanmay-db Mar 26, 2026
204c9a1
-
tanmay-db Mar 26, 2026
63b6e4d
Merge branch 'move-away-acc-id' of github.com:databricks/terraform-pr…
tanmay-db Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions internal/acceptance/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,35 +436,33 @@ func setDebugLogger() {

func LoadWorkspaceEnv(t *testing.T) {
initTest(t, "workspace")
if os.Getenv("DATABRICKS_ACCOUNT_ID") != "" {
Copy link
Copy Markdown
Contributor

@hectorcast-db hectorcast-db Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think tthat here we want to run it in both WORKSPCE and UC_WORKSPACE. That is the current behavior.

Copy link
Copy Markdown
Contributor Author

@tanmay-db tanmay-db Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Skipf(t)("Skipping workspace test on account level")
}
skipIfNotEnvironmentType(t, "WORKSPACE")
}

func LoadAccountEnv(t *testing.T) {
initTest(t, "account")
if os.Getenv("DATABRICKS_ACCOUNT_ID") == "" {
Skipf(t)("Skipping account test on workspace level")
}
skipIfNotEnvironmentType(t, "ACCOUNT")
}

func LoadUcwsEnv(t *testing.T) {
initTest(t, "ucws")
if os.Getenv("TEST_METASTORE_ID") == "" {
Skipf(t)("Skipping non-Unity Catalog test")
}
if os.Getenv("DATABRICKS_ACCOUNT_ID") != "" {
Skipf(t)("Skipping workspace test on account level")
}
skipIfNotEnvironmentType(t, "UC_WORKSPACE")
}

func LoadUcacctEnv(t *testing.T) {
initTest(t, "ucacct")
if os.Getenv("TEST_METASTORE_ID") == "" {
Skipf(t)("Skipping non-Unity Catalog test")
skipIfNotEnvironmentType(t, "UC_ACCOUNT")
}

// skipIfNotEnvironmentType skips the test if TEST_ENVIRONMENT_TYPE doesn't match the expected type.
// TEST_ENVIRONMENT_TYPE values: "ACCOUNT", "WORKSPACE", "UC_ACCOUNT", "UC_WORKSPACE".
func skipIfNotEnvironmentType(t *testing.T, expectedType string) {
envType := os.Getenv("TEST_ENVIRONMENT_TYPE")
if envType == "" {
Skipf(t)("Skipping test because TEST_ENVIRONMENT_TYPE is not set")
}
if os.Getenv("DATABRICKS_ACCOUNT_ID") == "" {
Skipf(t)("Skipping account test on workspace level")
if envType != expectedType {
Skipf(t)("Skipping %s test in %s environment", expectedType, envType)
}
}

Expand Down
Loading