Skip to content

[Internal] Host Agnostic Support for Current Config Data Source#5519

Merged
tanmay-db merged 5 commits intomainfrom
host-agnostic-current-config
Mar 26, 2026
Merged

[Internal] Host Agnostic Support for Current Config Data Source#5519
tanmay-db merged 5 commits intomainfrom
host-agnostic-current-config

Conversation

@tanmay-db
Copy link
Copy Markdown
Contributor

@tanmay-db tanmay-db commented Mar 24, 2026

Changes

  • Add an optional cloud argument to databricks_current_config that accepts aws, azure, or gcp
  • When set, cloud_type uses the provided value instead of relying on host-based detection
  • When not set, falls back to existing behavior (auto-detect from provider configuration)
  • Validated via StringInSlice — invalid or empty values are rejected at plan time

Tests

  • Unit tests: cloud override (gcp, azure, aws), account-level override, invalid value rejection, empty value rejection
  • Acceptance tests: cloud override at workspace level (aws, azure, gcp) and account level
  • Existing unit tests still pass
  • make fmt lint ws clean

@tanmay-db tanmay-db marked this pull request as ready for review March 25, 2026 09:37
@tanmay-db tanmay-db requested review from a team as code owners March 25, 2026 09:37
@tanmay-db tanmay-db requested review from parthban-db and removed request for a team and parthban-db March 25, 2026 09:37
@tanmay-db tanmay-db requested a review from hectorcast-db March 25, 2026 09:39
@tanmay-db tanmay-db temporarily deployed to test-trigger-is March 26, 2026 09:58 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 5519
  • Commit SHA: ce69446ada5c6e5241e1422b85aff1b26719123d

Checks will be approved automatically on success.

@tanmay-db tanmay-db temporarily deployed to test-trigger-is March 26, 2026 09:58 — with GitHub Actions Inactive
@tanmay-db tanmay-db added this pull request to the merge queue Mar 26, 2026
Merged via the queue into main with commit 12757f9 Mar 26, 2026
12 checks passed
@tanmay-db tanmay-db deleted the host-agnostic-current-config branch March 26, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants