[Internal] Fix databricks_users data source acceptance tests#5531
Open
[Internal] Fix databricks_users data source acceptance tests#5531
Conversation
Fix SCIM filters in acceptance tests that never matched the created
test users, causing the tests to silently return 0 results. Also fix
test name prefixes so CI routes them to the correct environments.
Filter fixes:
- dataSourceTemplate: "userName co testuser" -> "userName co tf-{RANDOM}"
to match created users tf-{RANDOM}-1@databricks.com
- dataSourceTemplateExtraAttributes: "userName eq me-{RANDOM}@example.com"
-> "userName eq tf-{RANDOM}-1@databricks.com" to match created user
Prefix fixes (CI routing):
- TestAccDataSource* (AccountLevel) -> TestMwsAccDataSource* (account env)
- TestWorkspaceDataSource* (WorkspaceLevel) -> TestAccDataSource* (workspace env)
These tests were previously dead — wrong prefixes meant CI never
selected them, and wrong filters meant they'd fail if they did run.
Co-authored-by: Isaac
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
Please ensure that the NEXT_CHANGELOG.md file is updated with any relevant changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix SCIM filters in acceptance tests that never matched the created test users, causing the tests to silently return 0 results. Also fix test name prefixes so CI routes them to the correct environments.
Filter fixes:
Prefix fixes (CI routing):
These tests were previously dead — wrong prefixes meant CI never selected them, and wrong filters meant they'd fail if they did run.
Co-authored-by: Isaac
Changes
Tests
make testrun locallydocs/folderinternal/acceptanceNEXT_CHANGELOG.mdfile