Skip to content

Conversation

@ghanse
Copy link
Collaborator

@ghanse ghanse commented Dec 8, 2025

Changes

This PR introduces Black as a Python code formatter. Type hints and docstrings have been updated for several modules:

  • datarange.py
  • nrange.py
  • daterange.py
  • All constraint modules
  • All distribution modules

Linked issues

N/A

Requirements

  • manually tested
  • updated documentation
  • updated demos
  • updated tests

@ghanse ghanse requested review from a team as code owners December 8, 2025 19:45
@ghanse ghanse requested review from anupkalburgi, nfx and suryasaitura-db and removed request for a team December 8, 2025 19:45
@ghanse
Copy link
Collaborator Author

ghanse commented Dec 8, 2025

This PR is going to be quite large. Any functional changes are in:

  • datarange.py
  • daterange.py
  • nrange.py
  • All constraints modules
  • All distributions modules

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 95.37223% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.10%. Comparing base (aae8bde) to head (3e1f5a2).
⚠️ Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
dbldatagen/constraints/constraint.py 82.85% 3 Missing and 3 partials ⚠️
dbldatagen/column_generation_spec.py 94.59% 2 Missing ⚠️
dbldatagen/constraints/unique_combinations.py 88.23% 1 Missing and 1 partial ⚠️
dbldatagen/data_generator.py 91.66% 2 Missing ⚠️
...datagen/datasets/multi_table_telephony_provider.py 90.90% 2 Missing ⚠️
dbldatagen/daterange.py 95.65% 2 Missing ⚠️
dbldatagen/nrange.py 97.14% 1 Missing and 1 partial ⚠️
dbldatagen/utils.py 83.33% 1 Missing and 1 partial ⚠️
dbldatagen/column_spec_options.py 90.00% 1 Missing ⚠️
...tagen/datasets/multi_table_sales_order_provider.py 95.65% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
- Coverage   92.87%   92.10%   -0.77%     
==========================================
  Files          42       47       +5     
  Lines        3577     4206     +629     
  Branches      631      763     +132     
==========================================
+ Hits         3322     3874     +552     
- Misses        145      186      +41     
- Partials      110      146      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ghanse ghanse requested a review from Copilot December 8, 2025 20:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces Black as the Python code formatter and applies it across tutorial files, test files, and utility scripts. The changes are purely cosmetic, focusing on consistent formatting without altering functionality.

Key Changes:

  • Applied Black formatter to tutorial scripts (1-4) and test files
  • Reformatted multi-line function calls, parameter lists, and data structures for improved readability
  • Added blank lines between function definitions per PEP 8 guidelines

Reviewed changes

Copilot reviewed 86 out of 87 changed files in this pull request and generated no comments.

File Description
tutorial/*.py Reformatted DataGenerator chains and SQL strings with proper line breaks
tests/test_*.py Applied Black formatting to test methods, parametrize decorators, and assertions
docs/utils/mk_requirements.py Split long string literals across multiple lines

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ghanse ghanse requested a review from Copilot December 8, 2025 23:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 86 out of 87 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@anupkalburgi anupkalburgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghanse ghanse requested a review from Copilot December 10, 2025 15:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 87 out of 88 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ghanse ghanse merged commit a3fd878 into master Dec 10, 2025
5 checks passed
@ghanse ghanse deleted the fmt_modules_003 branch December 10, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants