map_chunked implementation#99
Open
lorenzorubi-db wants to merge 3 commits intodatabrickslabs:masterfrom
Open
Conversation
nfx
requested changes
Feb 2, 2024
discoverx/explorer.py
Outdated
|
|
||
| return res | ||
|
|
||
| def map_chunked(self, f: Callable, tables_per_chunk: int, **kwargs) -> list[any]: |
Collaborator
There was a problem hiding this comment.
Suggested change
| def map_chunked(self, f: Callable, tables_per_chunk: int, **kwargs) -> list[any]: | |
| def map_chunked(self, f: Callable, tables_per_chunk: int, **kwargs) -> list[Any]: |
any is a function, not a type
setup.py
Outdated
| "delta-spark>=2.2.0", | ||
| "pandas<2.0.0", # From 2.0.0 onwards, pandas does not support iteritems() anymore, spark.createDataFrame will fail | ||
| "numpy<1.24", # From 1.24 onwards, module 'numpy' has no attribute 'bool'. | ||
| "more_itertools", |
Collaborator
There was a problem hiding this comment.
Create LPP ticket for this, otherwise re-implement a single function. Don't add whole library for the sake of a function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataExplorernew methodmap_chunkedas an alternative tomap:mapprocesses the tables one by onemap_chunkedprocesses the tables in chunks of sizetables_per_chunk