Skip to content

Conversation

@sundarshankar89
Copy link
Collaborator

@sundarshankar89 sundarshankar89 commented Aug 5, 2024

closes #708

The existing dashboard has been broken into 2.
For features unsupported by LSQL, we are using overrides to implement the required widgets.

Conditional formatting depends on databrickslabs/lsql#299

Screenshots:

REMORPH  Reconciliation Metrics
REMORPH  Aggregate Reconciliation Metrics

-- co-authored by @bishwajit-db and @sundarshankar89

@sundarshankar89 sundarshankar89 added feat/dashboards where queries are executed for databricks feat/recon making sure that remorphed query produces the same results as original labels Aug 5, 2024
@github-actions
Copy link

github-actions bot commented Aug 5, 2024

Coverage tests results

432 tests  ±0   392 ✅ ±0   3s ⏱️ ±0s
  6 suites ±0    40 💤 ±0 
  6 files   ±0     0 ❌ ±0 

Results for commit 202217c. ± Comparison against base commit 8405131.

♻️ This comment has been updated with latest results.

@sundarshankar89 sundarshankar89 self-assigned this Aug 6, 2024
@sundarshankar89
Copy link
Collaborator Author

sundarshankar89 commented Aug 7, 2024

updated description

@sundarshankar89
Copy link
Collaborator Author

@nfx why is it moved to in progress? it is blocked by lsql missing features.

# Conflicts:
#	pyproject.toml
#	src/databricks/labs/remorph/deployment/installation.py
#	src/databricks/labs/remorph/deployment/recon.py
#	src/databricks/labs/remorph/resources/reconcile/dashboards/Remorph-Reconciliation.lvdash.json
Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

Copy link
Contributor

@vijaypavann-db vijaypavann-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx merged commit dfc50e1 into main Oct 2, 2024
8 checks passed
@nfx nfx deleted the feature/lsql_dashboard branch October 2, 2024 13:09
sundarshankar89 added a commit to sundarshankar89/remorph that referenced this pull request Jan 2, 2025
closes databrickslabs#708 

The existing dashboard has been broken into 2.
For features unsupported by LSQL, we are using overrides to implement
the required widgets.

Conditional formatting depends on
databrickslabs/lsql#299

Screenshots:

![REMORPH Reconciliation
Metrics](https://github.com/user-attachments/assets/af7f6341-cecf-42d9-96b4-931a0347ed85)
![REMORPH Aggregate Reconciliation
Metrics](https://github.com/user-attachments/assets/2c70b071-e373-4ab4-8923-7706ae60b6ce)

-- co-authored by @bishwajit-db and @sundarshankar89

---------

Co-authored-by: Bishwajit <[email protected]>
sundarshankar89 added a commit to sundarshankar89/remorph that referenced this pull request Jan 3, 2025
closes databrickslabs#708 

The existing dashboard has been broken into 2.
For features unsupported by LSQL, we are using overrides to implement
the required widgets.

Conditional formatting depends on
databrickslabs/lsql#299

Screenshots:

![REMORPH Reconciliation
Metrics](https://github.com/user-attachments/assets/af7f6341-cecf-42d9-96b4-931a0347ed85)
![REMORPH Aggregate Reconciliation
Metrics](https://github.com/user-attachments/assets/2c70b071-e373-4ab4-8923-7706ae60b6ce)

-- co-authored by @bishwajit-db and @sundarshankar89

---------

Co-authored-by: Bishwajit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat/dashboards where queries are executed for databricks feat/recon making sure that remorphed query produces the same results as original

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TECH DEBT]: Use LSQL for Dashboards-as-code instead of unreadable JSON files

5 participants