Skip to content

Add property id to get service principal id #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 7, 2025
Merged

Add property id to get service principal id #170

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
42a0398
Add property 'id' to get service principal id
pritishpai Aug 7, 2025
ab6e2b9
Fix fmt
pritishpai Aug 7, 2025
3484849
Add unit test
pritishpai Aug 7, 2025
cff8012
Modify unit test to include service principal
pritishpai Aug 7, 2025
bc14e0a
fmt
pritishpai Aug 7, 2025
75ef1dc
fmt#2
pritishpai Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/databricks/labs/pytester/fixtures/iam.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,11 @@ def application_id(self) -> str:
assert self._service_principal.application_id is not None
return self._service_principal.application_id

@property
def id(self) -> str:
assert self._service_principal.id is not None
return self._service_principal.id

def __repr__(self):
return f'RunAs({self.display_name})'

Expand Down Expand Up @@ -339,8 +344,7 @@ def create(*, account_groups: list[str] | None = None):
workspace_id = ws.get_workspace_id()
service_principal = acc.service_principals.create(display_name=f'spn-{make_random()}')
assert service_principal.id is not None
service_principal_id = int(service_principal.id)
created_secret = acc.service_principal_secrets.create(service_principal_id)
created_secret = acc.service_principal_secrets.create(service_principal.id)
if account_groups:
group_mapping = {}
for group in acc.groups.list(attributes='id,displayName'):
Expand All @@ -354,15 +358,15 @@ def create(*, account_groups: list[str] | None = None):
acc.groups.patch(
group_id,
operations=[
Patch(PatchOp.ADD, 'members', [ComplexValue(value=str(service_principal_id)).as_dict()]),
Patch(PatchOp.ADD, 'members', [ComplexValue(value=str(service_principal.id)).as_dict()]),
],
schemas=[PatchSchema.URN_IETF_PARAMS_SCIM_API_MESSAGES_2_0_PATCH_OP],
)
permissions = [WorkspacePermission.USER]
acc.workspace_assignment.update(workspace_id, service_principal_id, permissions=permissions)
acc.workspace_assignment.update(workspace_id, int(service_principal.id), permissions=permissions)
ws_as_spn = _make_workspace_client(ws, created_secret, service_principal)

log_account_link('account service principal', f'users/serviceprincipals/{service_principal_id}')
log_account_link('account service principal', f'users/serviceprincipals/{service_principal.id}')

return RunAs(service_principal, ws_as_spn, env_or_skip)

Expand Down