Add and populate UCX workflow_runs table
#2754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCZuurmond
added
feat/workflow
Contributor
Author
|
JCZuurmond
commented
Sep 26, 2024
JCZuurmond
commented
Sep 26, 2024
nfx
requested changes
Sep 26, 2024
JCZuurmond
force-pushed
the
feat/add-workspace-scans-table
branch
from
f5f3ac2 to
cbaba94
Compare
nfx
reviewed
Sep 26, 2024
JCZuurmond
commented
Sep 27, 2024
Contributor
Author
JCZuurmond
left a comment
JCZuurmond
left a comment
There was a problem hiding this comment.
Forgot to hit submit on this review, maybe outdated
Contributor
Author
|
Note that this task will fail when there is no UCX catalog with the |
nfx
requested changes
Sep 27, 2024
Contributor
Author
Added |
JCZuurmond
commented
Sep 27, 2024
JCZuurmond
had a problem deploying
to
account-admin
GitHub Actions
Error
JCZuurmond
changed the title
workflow_runs artifact tableworkflow_runs table
JCZuurmond
force-pushed
the
feat/add-workspace-scans-table
branch
from
affe04a to
9502991
Compare
JCZuurmond
had a problem deploying
to
account-admin
GitHub Actions
Failure
|
❌ 108/109 passed, 1 failed, 3 skipped, 3h48m58s total ❌ test_running_real_migration_progress_job: AssertionError: assert False (24m9.909s)Running from acceptance #6259 |
nfx
requested changes
Sep 27, 2024
JCZuurmond
had a problem deploying
to
account-admin
GitHub Actions
Failure
3 tasks
asnare
requested changes
Sep 30, 2024
Contributor
asnare
left a comment
asnare
left a comment
There was a problem hiding this comment.
At the moment it seems to me that some of the requirements (or purpose) of this table aren't clear. To avoid rework I think this needs to be resolved before we can complete this PR.
JCZuurmond
had a problem deploying
to
account-admin
GitHub Actions
Error
JCZuurmond
had a problem deploying
to
account-admin
GitHub Actions
Failure
JCZuurmond
had a problem deploying
to
account-admin
GitHub Actions
Failure
Contributor
Author
|
Integration test fails due to a time out on the assessment job. This is happening also for the assessment integration test, but went unnoticed as the CI is not able to create issues anymore. This is blocking the PR at the moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add and populate workflow runs table
Linked issues
Resolves #2600
Functionality
migration-process-experimentalTests
TODO
parse_log_task--> only add it to the migration progress workflow for now