Tech debt: let HistoryEncoding work with string-based type annotations in addition to the normal type-based ones
#3068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dition to the normal class-based ones. This is needed for correct functioning if a dataclass is declared in a __future__.__annotations__ context: here python converts all type hints to strings (at which point the dataclass metaclass captures them) prior to deferred resolution.
|
✅ 6/6 passed, 15m15s total Running from acceptance #7025 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR cherry-picks some changes from #3039 that updated the
HistoryEncoderto work correctly with dataclasses that are declared with__future__.__annotations__in effect.When this annotation is in effect, python converts all type-hints during import/declaration into strings and then performs deferred resolution at a later stage. (This is why forward references work.) Unfortunately the dataclass mechanism captures field types prior to deferred resolution. This PR ensures that our type checking works anyway.
Linked issues
Cherry-picks from #3039.
Tests