-
Notifications
You must be signed in to change notification settings - Fork 111
docs: add cal integration #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@vachmara is attempting to deploy a commit to the Databuddy OSS Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughAdded Cal.com integration documentation and sidebar navigation support. The changes include a new sidebar navigation item linking to the Cal.com integration guide, the integration documentation page itself, and a corresponding metadata entry. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip ✨ Issue Enrichment is now available for GitHub issues!CodeRabbit can now help you manage issues more effectively:
Disable automatic issue enrichmentTo disable automatic issue enrichment, add the following to your issue_enrichment:
auto_enrich:
enabled: falseThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
set as draft until complete, it's missing the original PR to get merged, and the setting to enable cross origin tracking |
|
done! ping me when the cross origin tracking option is good so I will speed up things on cal side |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
apps/docs/components/sidebar-content.tsx(2 hunks)apps/docs/content/docs/Integrations/cal.mdx(1 hunks)apps/docs/content/docs/Integrations/meta.json(1 hunks)
🔇 Additional comments (8)
apps/docs/content/docs/Integrations/meta.json (1)
12-12: LGTM!The Cal.com entry is properly placed in the pages array and aligns with the new integration documentation.
apps/docs/components/sidebar-content.tsx (2)
140-144: LGTM!The sidebar item structure is consistent with other integrations, and the href correctly points to the new Cal.com documentation page.
11-11: This review comment references CalendarIcon on line 11 of sidebar-content.tsx, but the current codebase shows GoogleLogoIcon on line 11. CalendarIcon does not appear in this file's imports. The review comment is based on a code state that does not match the current repository.Likely an incorrect or invalid review comment.
apps/docs/content/docs/Integrations/cal.mdx (5)
1-4: LGTM!The frontmatter is properly formatted with a clear title and descriptive metadata.
6-10: LGTM!The introduction clearly explains the integration's value, and the TL;DR provides a helpful quick summary.
25-31: LGTM!The self-hosted instructions are clear and provide the necessary configuration details.
44-45: LGTM!The conclusion provides a clear call-to-action with an appropriate link to the Cal.com app.
12-22: The fileapps/docs/content/docs/Integrations/cal.mdxdoes not exist in the repository. The Integrations directory contains: framer.mdx, gtm.mdx, index.mdx, nextjs.mdx, react.mdx, shopify.mdx, stripe.mdx, and wordpress.mdx, but no cal.mdx file. This review comment references a file that is not present.Likely an incorrect or invalid review comment.
| ## Use case | ||
|
|
||
| You can use the **same Client ID** across your **main website** and **Cal.com booking pages** to track full user journeys. | ||
|
|
||
| Example: | ||
|
|
||
| - A visitor lands on `yourwebsite.com/pricing` → clicks “Book a demo” → schedules via your Cal.com page. | ||
| - In Databuddy, you can setup with page view your [**funnel**](/docs/dashboard#funnel-analysis), allowing you to measure drop-off, setup goals and optimize conversions. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Search for dashboard documentation files and verify funnel-analysis anchor
find apps/docs/content/docs -name "*dashboard*" -type fRepository: databuddy-analytics/Databuddy
Length of output: 109
🏁 Script executed:
#!/bin/bash
# Search for funnel-analysis or funnel content in dashboard documentation
rg -i "funnel" apps/docs/content/docs/ --type mdx --type md -nRepository: databuddy-analytics/Databuddy
Length of output: 100
🏁 Script executed:
#!/bin/bash
# Search for funnel content in dashboard.mdx without type filter
rg -i "funnel" apps/docs/content/docs/dashboard.mdx -nRepository: databuddy-analytics/Databuddy
Length of output: 1260
🏁 Script executed:
#!/bin/bash
# Also search for any heading or anchor that might be funnel-analysis
rg "##|funnel" apps/docs/content/docs/dashboard.mdx -i -nRepository: databuddy-analytics/Databuddy
Length of output: 2413
Fix grammar errors on line 41.
The sentence contains multiple grammatical issues that make it unclear:
-In Databuddy, you can setup with page view your [**funnel**](/docs/dashboard#funnel-analysis), allowing you to measure drop-off, setup goals and optimize conversions.
+In Databuddy, you can set up a [**funnel**](/docs/dashboard#funnel-analysis) using page views, allowing you to measure drop-off, set up goals, and optimize conversions.Changes:
- "setup" → "set up" (verb form)
- "with page view your" → "using page views" (clearer phrasing)
- "setup goals" → "set up goals" (verb form)
- Added missing Oxford comma
The dashboard link anchor is valid.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## Use case | |
| You can use the **same Client ID** across your **main website** and **Cal.com booking pages** to track full user journeys. | |
| Example: | |
| - A visitor lands on `yourwebsite.com/pricing` → clicks “Book a demo” → schedules via your Cal.com page. | |
| - In Databuddy, you can setup with page view your [**funnel**](/docs/dashboard#funnel-analysis), allowing you to measure drop-off, setup goals and optimize conversions. | |
| ## Use case | |
| You can use the **same Client ID** across your **main website** and **Cal.com booking pages** to track full user journeys. | |
| Example: | |
| - A visitor lands on `yourwebsite.com/pricing` → clicks "Book a demo" → schedules via your Cal.com page. | |
| - In Databuddy, you can set up a [**funnel**](/docs/dashboard#funnel-analysis) using page views, allowing you to measure drop-off, set up goals, and optimize conversions. |
🤖 Prompt for AI Agents
In apps/docs/content/docs/Integrations/cal.mdx around lines 34 to 42, fix the
grammar on line 41 by changing "setup" to the verb form "set up", replacing the
awkward phrase "with page view your" with "using page views", changing "setup
goals" to "set up goals", and add the Oxford comma; e.g. rewrite the sentence to
read: "In Databuddy, you can set up your funnel using page views, allowing you
to measure drop-off, set up goals, and optimize conversions."
|
It has been merge on the calcom side, is it ready on your side tho @izadoesdev ? |
|
Great, now we need to wait until it's deployed on prod calcom side |
Pull Request
Description
This pull request adds documentation and sidebar navigation support for the new Cal.com integration with Databuddy. The main changes include updating the sidebar to feature Cal.com, adding a dedicated integration guide, and registering Cal.com in the integrations metadata.
see Calcom PR
Checklist
Summary by CodeRabbit
New Features
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.