-
Notifications
You must be signed in to change notification settings - Fork 111
refactor: Extract flags cache key generation. #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sbansal1999 is attempting to deploy a commit to the Databuddy OSS Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughDocumentation formatting adjustments to code samples in the feature flags documentation. Indentation and line spacing are reformatted for consistency. No functional logic, control flow, or public API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)!(**/pages/_document.{ts,tsx,jsx})**/*.{ts,tsx,jsx}📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
Files:
🧠 Learnings (1)📚 Learning: 2025-12-25T14:32:46.935ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryFixed indentation in feature flags documentation by adding 2 spaces to all code blocks. The first level of indentation was being removed during rendering, causing improper code formatting in the documentation. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant MDX as feature-flags.mdx
participant Parser as MDX Parser
participant CodeBlock as CodeBlock Component
participant Browser as Browser Render
Dev->>MDX: Edit code block indentation
Note over MDX: Add 2 spaces to template literals
MDX->>Parser: Parse MDX file
Parser->>CodeBlock: Pass code with preserved indentation
CodeBlock->>Browser: Render formatted code
Note over Browser: First level indentation now preserved
|
Description
First level of indentation was getting removed earlier.
Checklist