-
Notifications
You must be signed in to change notification settings - Fork 301
Add multi-architecture support for Linux platforms and FreeBSD/Windows ARM64 #836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@yxxhero 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
…all script Co-authored-by: yxxhero <[email protected]>
…support Co-authored-by: yxxhero <[email protected]>
@copilot merge main branch. |
.goreleaser.yml
Outdated
ignore: | ||
- goos: freebsd | ||
goarch: arm64 | ||
- goos: windows | ||
goarch: arm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot why we should add those code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ignore
section prevents GoReleaser from building unsupported platform combinations.
The default
build includes both freebsd
and windows
in goos
, and arm64
in goarch
. Without these ignore rules, GoReleaser would build all combinations including freebsd-arm64
and windows-arm64
.
However, the install script only supports:
freebsd-amd64
(not arm64)windows-amd64
(not arm64)
So these ignore rules prevent building binaries that users cannot install, avoiding unnecessary build artifacts and potential confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot we can add those into install script. so please remove ignore
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the ignore
section from GoReleaser configuration and added freebsd-arm64 and windows-arm64 to the install script's supported platforms list. Now GoReleaser will build binaries for all architecture combinations and users on those platforms can successfully install the plugin. Commit: 45d47da
…rm64 support Co-authored-by: yxxhero <[email protected]>
This PR adds support for additional architectures to resolve installation failures on non-x86 platforms. Previously, users on architectures like s390x would encounter:
Changes Made
New Linux architectures now supported:
linux/arm/v6
(32-bit ARM EABI5)linux/arm/v7
(32-bit ARM EABI5)linux/ppc64le
(64-bit PowerPC little endian)linux/s390x
(64-bit IBM System z)New FreeBSD/Windows architectures now supported:
freebsd/arm64
(64-bit ARM)windows/arm64
(64-bit ARM)Updated build configuration:
dist
target to build all new architectures with appropriateGOARM
flagsVerification:
The plugin can now be successfully installed on all requested platforms, expanding compatibility from the original 6 supported platforms to 12 total platforms.
Fixes #436.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.