-
Notifications
You must be signed in to change notification settings - Fork 130
454882981_Student_Financial _Aid-IPEDS #1827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
454882981_Student_Financial _Aid-IPEDS #1827
Conversation
Summary of ChangesHello @susmitakumari-art, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the available data on student financial aid by incorporating detailed statistics from the IPEDS database. It provides a multi-year view of student cohorts, their financial aid status, and subsequent graduation outcomes across various types of educational institutions. This new data enhances the ability to analyze trends and impacts within the higher education financial landscape. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a large number of files to ingest student financial aid data from IPEDS. While the effort is appreciated, there are significant systemic issues across the PR that need to be addressed to ensure data quality, consistency, and maintainability. Key problems include: an inconsistent and confusing directory structure (e.g., 2018_2021 nested within 2016_2019), inconsistent file naming conventions, numerous data formatting errors in the input CSVs (like split headers and extra spaces), and critical typos in schema definitions and mappings (e.g., AdjustedChort instead of AdjustedCohort). Additionally, several log files and output files are misplaced, and important errors from the import process appear to have been ignored. I've added specific comments highlighting examples of these recurring issues. A thorough cleanup is highly recommended before this can be merged.
This PR is to ingest data for Number of full-time, first-time degree/certificate-seeking undergraduate students in the adjusted cohort, number receiving an award, and graduation rate within 150 percent of normal program completion time at Title IV institutions, by control of institution, level of institution, and type of aid received: United States, cohort years: 2010-2013,
2011-2014,
2012-2015,
2013-2016,
2014-2017,
2015-2018,
2016-2019,
2017-2020,
2018-2021