Skip to content

Conversation

@vish-cs
Copy link
Contributor

@vish-cs vish-cs commented Jan 9, 2026

  • Update version history for spanner ingestion
  • Use update_import_status cloud function for feed based imports
  • Update staging version file for feed based imports
  • Update import param names for consistent processing
  • Use http type handler for feed based imports
  • Use a single graph path instead of list

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @vish-cs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the parameter handling within the import automation system. It introduces a more consistent naming convention for import status parameters, enhances the parameter extraction utility to gracefully handle different casing styles, and expands the data points captured for import status. These changes aim to improve the clarity, maintainability, and extensibility of the import process by standardizing data representation and consolidating related logic.

Highlights

  • Parameter Naming Standardization: Standardized parameter names from execTime to executionTime and version to latestVersion across the workflow, documentation, and backend logic for consistency.
  • Consolidated Parameter Handling: The create_import_params function was removed, and its logic was merged into get_import_params, streamlining how import parameters are extracted and processed.
  • Automatic Case Conversion: The get_import_params function now includes logic to automatically convert incoming CamelCase or mixedCase request keys to snake_case for internal use, improving flexibility and reducing potential errors.
  • Extended Import Status Parameters: Added support for new optional parameters, graphPaths and nextRefresh, to provide more comprehensive import status information.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@vish-cs vish-cs requested a review from ajaits January 9, 2026 04:59
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up and standardizes the parameter names for import status updates, moving from camelCase to snake_case for consistency within the Python code. The refactoring also includes consolidating two functions into one, which improves maintainability by reducing code duplication. My review includes a couple of suggestions for import_utils.py to further enhance the parameter handling logic. One suggestion is for improving clarity by renaming a function parameter, and the other addresses a potential issue in how the next_refresh timestamp is calculated to prevent incorrect data from being stored.

@vish-cs vish-cs force-pushed the params branch 4 times, most recently from 4343496 to d9c5c63 Compare January 12, 2026 08:46
@vish-cs vish-cs changed the title Clean up import status params Import automation improvements Jan 12, 2026
- Update version history for spanner ingestion
- Use update_import_status cloud function for feed based imports
- Update staging version file for feed based imports
- Update import param names for consistent processing
- Use http type handler for feed based imports
- Use a single graph path instead of list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant