Skip to content

Conversation

@abhishekjaisw
Copy link

India_RBIStateDomesticProduct Data refresh updates in jan2026

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @abhishekjaisw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the India RBI State Domestic Product data by extending the dataset's end date and adapting the data extraction process to changes in the source's table structure. It includes improvements to the script's file path handling for better reliability and introduces new mappings for economic sectors. Furthermore, new statistical variable definitions are added to properly represent the refreshed and potentially expanded data.

Highlights

  • Data Refresh and Date Extension: The end_date for the India RBI State Domestic Product data has been updated from 2022 to 2025, signifying a refresh of the dataset to include more recent information.
  • Source Data Table Adjustments: The Python script's logic for processing tables has been updated to reflect new table number ranges (from 26-57 to 19-52), and corresponding changes were made in state_domestic_product_metadata.csv and state_domestic_product_pv_map.csv to align with the updated source data structure.
  • Robust Path Handling: The rbi_sdp_download.py script now uses absolute paths for config.json and the download_dir, making the data download process more robust and independent of the script's execution location.
  • New Economic Sector Mapping: A new mapping for 'FINANCIAL SERVICES' has been added to state_domestic_product_pv_map.csv, expanding the categorization of economic sectors.
  • New Statistical Variable Definitions: Two new MCF files, state_domestic_product_output_stat_vars.mcf and state_domestic_product_output_stat_vars_schema.mcf, have been added to define new statistical variables and their associated schema, supporting the expanded and refreshed dataset.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the India RBI State Domestic Product data import. The changes include updating table number ranges in the download script and CSV mapping files, extending the end date, and adding a new 'FINANCIAL SERVICES' economic sector. The download script is also improved to use absolute paths, which makes it more robust.

I have two main suggestions:

  1. In rbi_sdp_download.py, the table number range should be moved to config.json to avoid hardcoding and improve maintainability.
  2. In the new test schema file state_domestic_product_output_stat_vars_schema.mcf, the rangeIncludes for the economicSector property appears to be incorrect for the values being used.

Details are in the specific comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant