-
Notifications
You must be signed in to change notification settings - Fork 130
India_RBIStateDomesticProduct Data refresh updates in jan2026 #1838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
India_RBIStateDomesticProduct Data refresh updates in jan2026 #1838
Conversation
Summary of ChangesHello @abhishekjaisw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the India RBI State Domestic Product data by extending the dataset's end date and adapting the data extraction process to changes in the source's table structure. It includes improvements to the script's file path handling for better reliability and introduces new mappings for economic sectors. Furthermore, new statistical variable definitions are added to properly represent the refreshed and potentially expanded data. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the India RBI State Domestic Product data import. The changes include updating table number ranges in the download script and CSV mapping files, extending the end date, and adding a new 'FINANCIAL SERVICES' economic sector. The download script is also improved to use absolute paths, which makes it more robust.
I have two main suggestions:
- In
rbi_sdp_download.py, the table number range should be moved toconfig.jsonto avoid hardcoding and improve maintainability. - In the new test schema file
state_domestic_product_output_stat_vars_schema.mcf, therangeIncludesfor theeconomicSectorproperty appears to be incorrect for the values being used.
Details are in the specific comments.
India_RBIStateDomesticProduct Data refresh updates in jan2026