[Apigee] For Keyur

[gmechali]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @gmechali, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces configuration changes to the Apigee proxy setup to enhance handling of potentially large or long-running API requests and responses. It primarily focuses on disabling HTTP compression to ensure consistent data transfer and enabling request/response streaming, alongside increasing I/O timeouts, to support more robust communication with backend services.

Highlights

• Disable Compression Policy: A new Apigee AssignMessage policy named am-disable-compression has been introduced. This policy explicitly disables HTTP compression by setting the Accept-Encoding header to identity in the request.
• Policy Application: The newly created am-disable-compression policy is now applied to the api proxy in the nonprod environment and also integrated into the PreFlow request of the mcp.template target endpoint.
• Streaming and Timeout Configuration: Request streaming has been enabled for both the api proxy endpoint and the mcp.template target endpoint. Additionally, the io.timeout.millis property has been set to 300000 (5 minutes) for these connections to accommodate longer-running operations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request configures Apigee to support streaming, likely for large payloads, by enabling request streaming, increasing timeouts, and adding a policy to disable response compression for the MCP target. While the changes appear to correctly enable streaming, there is a critical issue: the new am-disable-compression policy is not configured for the production environment, which will cause production deployments to fail. Additionally, the newly introduced 5-minute I/O timeout on the proxy endpoint is quite long and could pose a resource exhaustion risk.

[gemini-code-assist]

The new policy am-disable-compression is configured for the nonprod environment, but it is missing from the corresponding prod.yaml file. The mcp.template.xml target endpoint, which is used for both environments, now references this policy. This discrepancy will cause deployments to the prod environment to fail due to a missing policy. To fix this, please also add am-disable-compression to the policies list in deploy/apigee/envs/prod.yaml.

[gemini-code-assist]

A 5-minute I/O timeout (300000 ms) is being introduced. While this might be necessary for large streaming transfers, such a long timeout can make the proxy vulnerable to resource exhaustion, for instance through slowloris-type DoS attacks where clients maintain connections for long periods. Please evaluate if this timeout duration is essential. If so, it would be good practice to add an XML comment explaining the reason for this long timeout to aid future maintenance.