feat: add V2RecognizePlaces RPC endpoint to replace v1

[rohitkumarbhagat]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new version of the RecognizePlaces RPC endpoint, V2RecognizePlaces, to modernize and improve the natural language place recognition functionality. The changes involve updating gRPC dependencies, streamlining generated code, and ensuring that both the developer and reconnaissance documentation reflect the new API. The updated test suite validates the behavior of both the old and new endpoints, facilitating a smooth transition and maintaining robust functionality.

Highlights

• New RPC Endpoint: A new V2RecognizePlaces RPC endpoint has been introduced, designed to replace the existing V1 version for recognizing places from natural language queries.
• gRPC Version Updates: The protoc-gen-go-grpc version has been updated from v1.6.0 to v1.3.0, and the required gRPC-Go support package version has been adjusted from v1.64.0 to v1.32.0.
• Code Generation Refinement: Generated gRPC client code has been cleaned up by removing redundant grpc.StaticMethod() calls, which are no longer necessary with newer gRPC versions.
• Developer Documentation Update: The developer guide now includes instructions for installing golangci-lint, and the reconnaissance guide has been updated to mention the availability of the new /v2/recognize/places endpoint.
• Test Suite Enhancement: The recognize_places golden test suite has been enhanced to cover both the V1 and the newly introduced V2 RecognizePlaces API calls, ensuring comprehensive testing.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces the V2RecognizePlaces RPC endpoint as a replacement for the v1 version. The changes span across proto definitions, generated gRPC code, server handlers, and documentation. Tests have been commendably updated to cover both API versions. However, my review highlights a few concerns. The developer guide contains an incorrect installation command for golangci-lint. More critically, regenerating the gRPC code with an older tool version has removed the grpc.StaticMethod() option, potentially impacting client-side retry reliability, and also removed a valuable startup safety check for server implementations, which increases fragility and goes against robust error handling principles. These issues should be addressed to ensure developer experience and service robustness.

[n-h-diaz]

Thanks!