Skip to content

[Vis Tools] Don't use link in map ranking list #5872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliawu merged 8 commits into from
Jan 21, 2026
Merged

[Vis Tools] Don't use link in map ranking list #5872

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
37b6880
Remove link from ranking list
juliawu Dec 23, 2025
80303e6
Remove extra braces
juliawu Dec 26, 2025
3bf490c
update webdriver test
juliawu Dec 26, 2025
82edf87
lint
juliawu Dec 26, 2025
8852042
lint again
juliawu Dec 26, 2025
d7813a9
add space to title
juliawu Dec 26, 2025
81f962d
Merge branch 'master' into map-ranking-links
juliawu Jan 20, 2026
e0b9331
Merge branch 'master' into map-ranking-links
juliawu Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 8 additions & 23 deletions static/js/tools/map/place_details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@ import {
import { MAP_CONTAINER_ID } from "./chart";
import { Context, DisplayOptions, PlaceInfo, StatVar } from "./context";
import {
getAllChildPlaceTypes,
getParentPlaces,
getRedirectLink,
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With the removal of the usages here, it appears the functions getRedirectLink and getAllChildPlaceTypes are no longer used anywhere. To improve code maintainability, please consider removing them from static/js/tools/map/util.ts to remove dead code.

Copy link
Contributor Author

@juliawu juliawu Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

False. getRedirectLink is still used by the disaster maps and getAllChildPlaceTypes is still used by the disaster maps and place search. I am leaving them as is.

} from "./util";

interface PlaceDetailsPropType {
Expand Down Expand Up @@ -133,8 +131,8 @@ export function PlaceDetails(props: PlaceDetailsPropType): JSX.Element {
);
}

function highlightPlace(e: React.MouseEvent<HTMLAnchorElement>): void {
const target = e.target as HTMLAnchorElement;
function highlightPlace(e: React.MouseEvent<HTMLElement>): void {
const target = e.target as HTMLElement;
const placeDcid = target.dataset.geodcid;
highlightPlaceToggle(
document.getElementById(MAP_CONTAINER_ID),
Expand All @@ -143,8 +141,8 @@ function highlightPlace(e: React.MouseEvent<HTMLAnchorElement>): void {
);
}

function unhighlightPlace(e: React.MouseEvent<HTMLAnchorElement>): void {
const target = e.target as HTMLAnchorElement;
function unhighlightPlace(e: React.MouseEvent<HTMLElement>): void {
const target = e.target as HTMLElement;
const placeDcid = target.dataset.geodcid;
highlightPlaceToggle(
document.getElementById(MAP_CONTAINER_ID),
Expand Down Expand Up @@ -183,31 +181,18 @@ function getListItemElement(
enclosingPlace,
placeInfo.parentPlaces
);
const redirectLink = getRedirectLink(
statVar,
place,
parentPlaces,
placeInfo.mapPointPlaceType,
display
);
const shouldBeClickable = !_.isEmpty(
getAllChildPlaceTypes(place, parentPlaces)
);

return (
<div key={place.dcid}>
{itemNumber && `${itemNumber}. `}
{shouldBeClickable ? (
<a
href={redirectLink}
{
<span
data-geodcid={place.dcid}
onMouseEnter={highlightPlace}
onMouseLeave={unhighlightPlace}
>
{place.name}
</a>
) : (
`${place.name}`
)}
</span>}
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The curly braces {...} around the <span> element are not necessary here. You can remove them to make the JSX cleaner and more readable.

      <span
        data-geodcid={place.dcid}
        onMouseEnter={highlightPlace}
        onMouseLeave={unhighlightPlace}
      >
        {place.name}
      </span>

{date}: {value}
</div>
);
Expand Down
Loading