[Cloud Deploy] Standardize parameters to MIXER_GITHASH and WEBSITE_GITHASH

[hqpho]

This change updates the Cloud Build configuration files and deployment scripts to use MIXER_GITHASH and WEBSITE_GITHASH parameters exclusively, removing the unrecognized mixer.githash and website.githash parameters.

[gemini-code-assist]

Summary of Changes

Hello @hqpho, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the Cloud Deploy setup by enforcing a uniform naming scheme for critical deployment parameters. By exclusively using MIXER_GITHASH and WEBSITE_GITHASH, it eliminates ambiguity and potential issues arising from deprecated or unrecognized parameter formats, thereby enhancing the reliability and maintainability of the deployment pipelines.

Highlights

• Parameter Standardization: The pull request standardizes the deployment parameters used in Cloud Build configurations and deployment scripts, ensuring consistent naming conventions.
• Removal of Unrecognized Parameters: It removes the previously unrecognized mixer.githash and website.githash parameters, replacing them with their standardized counterparts, MIXER_GITHASH and WEBSITE_GITHASH.
• Configuration File Updates: Updates have been applied to cloudbuild.deploy_mixer.yaml, cloudbuild.deploy_website_mixer.yaml, deploy_mixer_cloud_deploy.sh, and deploy_website_cloud_deploy.sh to reflect these parameter changes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request standardizes deployment parameters in Cloud Build configurations and deployment scripts by replacing unrecognized mixer.githash and website.githash with MIXER_GITHASH and WEBSITE_GITHASH, resolving redundancy and fixing a bug. However, a security audit identified several high-severity command injection vulnerabilities in these scripts. Untrusted inputs (build substitution variables and script arguments) are used to construct shell commands without proper validation, potentially allowing arbitrary code execution. It is critical to add validation for all githash inputs and ensure all variables used in shell commands are properly quoted and sanitized.

[clincoln8]

I think this might be covered by #5903. But will need to take a closer look!