Set the embeddings server url for CDC mixer

[clincoln8]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @clincoln8, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the cdc mixer service's startup script by implementing conditional logic to configure the embeddings server URL. This change allows the mixer to connect to an embeddings server only when a specific model-enabling flag is active, providing greater flexibility in deployment and resource management.

Highlights

• Mixer Configuration: The pull request introduces a mechanism to dynamically set the --embeddings_server_url argument for the mixer binary.
• Conditional Embeddings Server URL: The embeddings server URL (localhost:6060) is now conditionally applied to the mixer command only when the ENABLE_MODEL environment variable is set to "true".

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to add a conditional command-line argument --embeddings_server_url to the mixer command based on the ENABLE_MODEL environment variable. However, a high-severity command injection vulnerability has been identified in the build/cdc_services/run.sh script. The introduction of the $MIXER_ARGS variable without proper shell quoting, along with existing unquoted variables, creates a risk of arbitrary command execution. A more robust approach using a bash array for handling optional arguments is suggested to improve maintainability and mitigate word splitting issues.

[gemini-code-assist]

This line introduces a high-severity command injection vulnerability due to the unquoted shell variable $MIXER_ARGS. Unquoted variables can lead to word splitting and arbitrary command execution if an attacker controls environment variables, continuing an insecure pattern with other unquoted variables like $DC_API_ROOT and $CLOUDSQL_INSTANCE. To prevent this and ensure secure argument handling, it is critical to double-quote $MIXER_ARGS (e.g., "$MIXER_ARGS"). If $MIXER_ARGS is intended to be an array of arguments, then "${MIXER_ARGS[@]}" would be the correct and secure way to expand it, ensuring each argument is passed as a separate word. Always double-quote variables in commands as a security best practice.

Suggested change

	$MIXER_ARGS &
	"$MIXER_ARGS" &

[gemini-code-assist]

For better robustness and to avoid issues with word splitting, it's recommended to use an array for storing optional command-line arguments in bash. This is safer if arguments with spaces are ever needed in the future. This change should be made in conjunction with updating how MIXER_ARGS is used on line 76.

Suggested change

	MIXER_ARGS=""
	if [[ $ENABLE_MODEL == "true" ]]; then
	MIXER_ARGS="--embeddings_server_url=localhost:6060"
	fi
	MIXER_ARGS=()
	if [[ $ENABLE_MODEL == "true" ]]; then
	MIXER_ARGS+=(--embeddings_server_url=localhost:6060)
	fi