-
Notifications
You must be signed in to change notification settings - Fork 189
Fix #832: Markdown export has correct table sizes #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ate tables for servers and models.
|
Please also add a test in https://github.com/datacontract/datacontract-cli/blob/main/tests/test_export_markdown.py |
…d now render correctly on all renderers.
|
Why did you not follow hunyadi/md2conf#142 advice and use |
|
@simonharrer because I haven't tried it yet. As far as example files go (https://github.com/bitol-io/open-data-contract-standard/tree/main/docs/examples), I haven't come across one that would look terrible with many columns while working with |
|
@grepwood @simonharrer any update on this PR? |
|
I'll try and resolve the conflicts |
|
Done. I hope people find it useful. I'm afraid I can't use the advice from hunyadi/md2conf#142 because when a real solution to #837 materializes, I won't be needing Markdown conversion as an intermediate step between ODCS yamls and CSF. To put this in simpler terms, this is the workflow I have currently out of necessity: This is the workflow I will be driving towards achieving: For documents that I process that are originally written in Markdown, |
Export to Markdown will now generate appropriate tables for servers and models.
If a server on the list has an exclusive property, a column for it will be created, but for other servers that don't have it, it will generate an empty cell.
Likewise for models, if one field has an exclusive property that other fields don't have, the table will account for it, but leave empty cells for deficient fields.
How do I run tests and ruff? What kind of change in README.md is expected?