Fixes SQL syntax errors when using single quotes in validValues or missingValues for Soda quality checks.
#981
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When values containing single quotes (e.g.,
"peter's") were used invalidValuesormissingValues, Soda would generate invalid SQL likeWHERE field IN ('peter's'), causing syntax errors.This fix escapes single quotes by doubling them (SQL standard) before generating SodaCL YAML, resulting in valid SQL:
WHERE field IN ('peter''s').Checklist
test_data_contract_checks.pypassChanges
check_property_invalid_values()to escape single quotes in validValuescheck_property_missing_values()to escape single quotes in missingValues