Skip to content

Commit 74586ee

Browse files
committed
perf: Optimize the speed of data querying
1 parent 0e09a0b commit 74586ee

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

backend/apps/datasource/crud/datasource.py

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -384,17 +384,19 @@ def get_table_schema(session: SessionDep, current_user: CurrentUser, ds: CoreDat
384384
else:
385385
schema_table += f", {table_comment}\n[\n"
386386

387-
field_list = []
388-
for field in obj.fields:
389-
field_comment = ''
390-
if field.custom_comment:
391-
field_comment = field.custom_comment.strip()
392-
if field_comment == '':
393-
field_list.append(f"({field.field_name}:{field.field_type})")
394-
else:
395-
field_list.append(f"({field.field_name}:{field.field_type}, {field_comment})")
396-
schema_table += ",\n".join(field_list)
397-
schema_table += '\n]\n'
387+
if obj.fields:
388+
field_list = []
389+
for field in obj.fields:
390+
field_comment = ''
391+
if field.custom_comment:
392+
field_comment = field.custom_comment.strip()
393+
if field_comment == '':
394+
field_list.append(f"({field.field_name}:{field.field_type})")
395+
else:
396+
field_list.append(f"({field.field_name}:{field.field_type}, {field_comment})")
397+
schema_table += ",\n".join(field_list)
398+
schema_table += '\n]\n'
399+
398400
t_obj = {"id": obj.table.id, "schema_table": schema_table}
399401
tables.append(t_obj)
400402
all_tables.append(t_obj)

backend/apps/datasource/crud/permission.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ def get_row_permission_filters(session: SessionDep, current_user: CurrentUser, d
3737
if p_list is not None and u_list is not None and permission.id in p_list and (
3838
current_user.id in u_list or f'{current_user.id}' in u_list):
3939
flag = True
40+
break
4041
if flag:
4142
res.append(transRecord2DTO(session, permission))
4243
where_str = transFilterTree(session, res, ds)
@@ -64,6 +65,7 @@ def get_column_permission_fields(session: SessionDep, current_user: CurrentUser,
6465
if p_list is not None and u_list is not None and permission.id in p_list and (
6566
current_user.id in u_list or f'{current_user.id}' in u_list):
6667
flag = True
68+
break
6769
if flag:
6870
permission_list = json.loads(permission.permissions)
6971
fields = filter_list(fields, permission_list)

0 commit comments

Comments
 (0)