Skip to content
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ http-body = {version = "0.4.5" }
itertools = "0.13.0"
lazy_static = "1.4.0"
log = "0.4.22"
num_cpus = "1.16.0"
object_store = { version = "0.10.2", features = ["aws"], optional = true }
parking_lot = "0.12.3"
pin-project-lite = {version = "0.2.14" }
prost = "0.12.3"
ratatui = "0.28.0"
Expand Down
2 changes: 0 additions & 2 deletions f.csv

This file was deleted.

2 changes: 1 addition & 1 deletion src/args.rs
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ pub struct DftArgs {
#[clap(short = 'n', help = "Set the number of benchmark iterations to run")]
pub benchmark_iterations: Option<usize>,

#[cfg(feature = "flightsql")]
#[cfg(any(feature = "flightsql", feature = "experimental-flightsql-server"))]
#[clap(long, help = "Set the host and port to be used for FlightSQL")]
pub flightsql_host: Option<String>,
}
Expand Down
14 changes: 14 additions & 0 deletions src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,10 @@ pub struct ExecutionConfig {
pub tui_batch_size: usize,
#[serde(default = "default_flightsql_server_batch_size")]
pub flightsql_server_batch_size: usize,
#[serde(default = "default_dedicated_executor_enabled")]
pub dedicated_executor_enabled: bool,
#[serde(default = "default_dedicated_executor_threads_percent")]
pub dedicated_executor_threads_percent: f64,
}

fn default_ddl_path() -> Option<PathBuf> {
Expand Down Expand Up @@ -204,6 +208,14 @@ fn default_flightsql_server_batch_size() -> usize {
8092
}

fn default_dedicated_executor_enabled() -> bool {
false
}

fn default_dedicated_executor_threads_percent() -> f64 {
0.75
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default we give the dedicated executor 75% of available CPU threads - since this in config it is configurable


impl Default for ExecutionConfig {
fn default() -> Self {
Self {
Expand All @@ -213,6 +225,8 @@ impl Default for ExecutionConfig {
cli_batch_size: default_cli_batch_size(),
tui_batch_size: default_tui_batch_size(),
flightsql_server_batch_size: default_flightsql_server_batch_size(),
dedicated_executor_enabled: default_dedicated_executor_enabled(),
dedicated_executor_threads_percent: default_dedicated_executor_threads_percent(),
}
}
}
Expand Down
Loading