Add plan validations to TPCH tests #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NGA-TRAN
approved these changes
Aug 22, 2025
Collaborator
NGA-TRAN
left a comment
NGA-TRAN
left a comment
There was a problem hiding this comment.
This is exactly what I need to examine what we are able to do today and propose some optimization. I also plan to do something like this but on different combinations of files. E.g. scale 10 and the files are sorted on different columns and many many files per tables
gabotechs
force-pushed
the
gabrielmusat/add-tpch-plans
branch
from
6d84d9b to
3ce1089
Compare
Base automatically changed from
gabrielmusat/introduce-distributed-ext
to
main
August 25, 2025 18:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the TPCH tests to also assert the produced distributed plan. This will ensure that not only results are correct, but they plans get properly distributed.