Refactor arrow_flight_read.rs and friends #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabotechs
commented
Aug 25, 2025
src/plan/combined.rs
Outdated
Collaborator
Author
There was a problem hiding this comment.
futures::stream::select() does exactly this, so I'm using that instead in this PR.
gabotechs
force-pushed
the
gabrielmusat/refactor-arrow-flight-read
branch
from
2bdadca to
d0fad3a
Compare
NGA-TRAN
approved these changes
Aug 26, 2025
Collaborator
NGA-TRAN
left a comment
NGA-TRAN
left a comment
There was a problem hiding this comment.
Nice refactor to capture errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of propagating execution metrics up in the stages stack, I ended up cleaning up some ArrowFightExec stuff.
The
arrow_flight_read.rsfile along with thedo_get.rswill need to be extended with execution metrics propagation, so cleaning this up now will make a future PR smaller and more digestible.