Fix panics in tests and un-ignore working tests #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… uncomment working tests
gabotechs
commented
Sep 3, 2025
| use datafusion::physical_plan::ExecutionPlan; | ||
| use std::sync::Arc; | ||
|
|
||
| pub fn distribute_aggregate( |
Collaborator
Author
There was a problem hiding this comment.
They way function was distributing a plan for the tests is just wrong, so now the normal planner is used.
NGA-TRAN
approved these changes
Sep 3, 2025
| │partitions [out:3 <-- in:1 ] RepartitionExec: partitioning=RoundRobinBatch(3), input_partitions=1 | ||
| │partitions [out:1 <-- in:1 ] PartitionIsolatorExec [providing upto 1 partitions] | ||
| │partitions [out:1 <-- in:1 ] AggregateExec: mode=Partial, gby=[RainToday@0 as RainToday], aggr=[count(Int64(1))] | ||
| │partitions [out:1 ] DataSourceExec: file_groups={1 group: [[/testdata/weather.parquet]]}, projection=[RainToday], file_type=parquet |
Collaborator
There was a problem hiding this comment.
I am glad we already have available tests to verify the fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #110
Previously, the
ArrowFlightReadExecnode could choose any partitioning scheme regardless of the child that was passed, but in reality it should be exposing the child partitioning scheme unmodified, as it's pretty just a network passthrough.Also,
ArrowFLightReadExecis not really prepared to have something other than aRepartitionExecas a child, so this PR also accounts for that in the tests while manually building a distributed plan.Additionally, some tests are unignored, as they are working now.