Skip to content

Conversation

@gabotechs
Copy link
Collaborator

@gabotechs gabotechs commented Sep 5, 2025

Just some minor code improvements for readability and saving some lines.

NGA-TRAN
NGA-TRAN previously approved these changes Sep 5, 2025
Copy link
Collaborator

@NGA-TRAN NGA-TRAN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense


// Rather than executing the `StageExec` itself, we want to execute the inner plan instead,
// as executing `StageExec` performs some worker assignation that should have already been
// done in the head stage.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and useful comment

Base automatically changed from gabrielmusat/cleanup to main September 5, 2025 15:11
@gabotechs gabotechs dismissed NGA-TRAN’s stale review September 5, 2025 15:11

The base branch was changed.

# Conflicts:
#	src/execution_plans/stage.rs
#	src/flight_service/do_get.rs
@gabotechs gabotechs force-pushed the gabrielmusat/simplification branch from 625399f to 65be54a Compare September 5, 2025 15:55
@gabotechs gabotechs merged commit bad700d into main Sep 5, 2025
7 of 8 checks passed
@gabotechs gabotechs deleted the gabrielmusat/simplification branch September 5, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants