move chrono out of optional deps so project can compile #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayshrivastava
approved these changes
Sep 18, 2025
Merged
adriangb
added a commit
to pydantic/datafusion-distributed
that referenced
this pull request
Sep 24, 2025
It was moved into the main deps in datafusion-contrib#143. This clears up some warnings about unused imports and variables
robtandy
pushed a commit
that referenced
this pull request
Sep 24, 2025
It was moved into the main deps in #143. This clears up some warnings about unused imports and variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
lib.rsincludes the module metrics, the project did not compile without the integration test feature. Movingchronoto a regular dependency fixes the problem.@jayshrivastava, or did I miss something?