Address public api weak points #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabotechs
force-pushed
the
gabrielmusat/address-public-api-weakpoints
branch
from
5fa6c7b to
7925912
Compare
gabotechs
force-pushed
the
gabrielmusat/address-public-api-weakpoints
branch
from
7925912 to
b2a5d0e
Compare
gabotechs
commented
Sep 26, 2025
| // TODO: It's not yet on DF 49, once upgrading to DF 50 we can remove this | ||
|
|
||
| // Idea taken from | ||
| // https://github.com/apache/datafusion/blob/0eebc0c7c0ffcd1514f5c6d0f8e2b6d0c69a07f5/datafusion-examples/examples/composed_extension_codec.rs#L236-L291 |
Collaborator
Author
There was a problem hiding this comment.
This code was previously taken from an example upstream. However, in version 50, there's a better version of this same code living in the datafusion-proto package, so I took it.
Comment on lines
+27
to
+29
| let mut codecs: Vec<Arc<dyn PhysicalExtensionCodec>> = vec![Arc::new(DistributedCodec {})]; | ||
| codecs.extend(get_distributed_user_codecs(cfg)); | ||
| ComposedPhysicalExtensionCodec::new(codecs) |
Collaborator
Author
There was a problem hiding this comment.
Now users can provide more than 1 codec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some improvement points I've discovered while playing with the public API:
Arc<dyn PhysicalExtensionCodec>, it only allows to provide non-dynamic codecs. This adds a newwith_distributed_user_codec_arcandset_distributed_user_codec_arcvariants for providing Arc-wrapped dynamic user codecsDistributedTaskContextandNetworkCoalesceExec. These structures where meant to be part of the public API, but they were not exposed.