fix(ttl_map): two minor fixes for ttl_map configuration parsing #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayshrivastava
approved these changes
Nov 17, 2025
Collaborator
jayshrivastava
left a comment
jayshrivastava
left a comment
There was a problem hiding this comment.
Looks good. Thanks for doing this! Let's add a test case for this too.
This commit adds two small changes to improve how we parse TTLMapConfigs. 1. It strictly enforces that `tick` is an integer multiple of `ttl`. Previously, we only recommened that in comments, with the consequence that: ``` true_ttl = desired_ttl - (desired_ttl % tick) <= desired_ttl ``` In the worst case, if `tick` is close to `ttl / 2` then the true `ttl` would be equivalent to `tick`. For example, if the requested `ttl` was 60 seconds, and the tick was 31 seconds, we would only allocate a single list of inputs to delete and free them every tick. 2. There was a small bug in the validation logic that did not correctly validate that tick was nonzero due to an incorrect application of DeMorgan's law. This commit fixes that to correctly check that `tick` is nonzero.
ruchirK
force-pushed
the
fix-ttl-tick-multiple
branch
from
d647623 to
ee94bb4
Compare
Contributor
Author
Done + also changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two small changes to improve how we parse TTLMapConfigs.
tickis an integer multiple ofttl. Previously, we only recommened that in comments, with the consequence that:In the worst case, if
tickis close tottl / 2then the truettlwould be equivalent totick. For example, if the requestedttlwas 60 seconds, and the tick was 31 seconds, we would only allocate a single list of inputs to delete and free them every tick.tickis nonzero.