Improve default task estimator #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabotechs
force-pushed
the
gabrielmusat/improve-default-task-estimator
branch
2 times, most recently
from
97d388c to
da7997e
Compare
gabotechs
force-pushed
the
gabrielmusat/improve-default-task-estimator
branch
from
da7997e to
e5cd77d
Compare
LiaCastaneda
approved these changes
Dec 31, 2025
Collaborator
LiaCastaneda
left a comment
LiaCastaneda
left a comment
There was a problem hiding this comment.
This makes sense to me. Just out of curiosity, do you know what's DataFusion thereshold to split a physical file into multiple PartitionedFiles?
Collaborator
Author
|
I think it's this one: https://github.com/apache/datafusion/blob/main/datafusion/common/src/config.rs#L937-L937, so if I'm reading it correctly it's 10Mb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the default task estimator by selecting the task count based on the number of file partitions rather than the number of actual files themselves