Skip to content

Conversation

@gabotechs
Copy link
Collaborator

@gabotechs gabotechs commented Jan 2, 2026

This is a docs-specific PR that:

  • Improves the docs by revisiting the wording and the terminology used
  • Adds an example for distributing queries containing custom execution plans

@gabotechs gabotechs force-pushed the gabrielmusat/add-custom-execution-plan-example branch from d849092 to 39a9509 Compare January 2, 2026 07:27
@gabotechs gabotechs changed the base branch from main to gabrielmusat/adapt-benchmarks-to-more-datasets January 2, 2026 07:28
@gabotechs gabotechs force-pushed the gabrielmusat/adapt-benchmarks-to-more-datasets branch from 10b13f3 to d2241c0 Compare January 2, 2026 07:29
@gabotechs gabotechs force-pushed the gabrielmusat/add-custom-execution-plan-example branch 2 times, most recently from 7adbc9c to 84e6d8a Compare January 2, 2026 07:49
Base automatically changed from gabrielmusat/adapt-benchmarks-to-more-datasets to main January 2, 2026 10:44
@gabotechs gabotechs force-pushed the gabrielmusat/add-custom-execution-plan-example branch from 84e6d8a to f2b4fed Compare January 2, 2026 10:45
@JSOD11
Copy link
Contributor

JSOD11 commented Jan 6, 2026

Looks good to me, just made a few wording suggestions in the docs.

I like the code example you came up with, I think it highlights the behavior of the TaskEstimator well. I ran your examples and they work for me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is NetworkCoalesceExec at the top not considered a stage? Do stage indices start at 0 or 1? It could possibly be helpful to make that explicit by writing e.g. Stage i where i is the stage index rather than just stage.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is NetworkCoalesceExec at the top not considered a stage?

I don't think so. That part of the plan gets executed locally in a non-distributed context, so we usually talk about it as the "head" of the plan. It might be nice to choose a specific term for that though.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For stage enumeration, I'd not over index to much about it in this drawing, as I wanted to land it as clean as possible. There's not a strong enumeration order requirement, fwiw stage numbers could be just random numbers and it would work the same, so I think it's fine to not represent it in this drawing

Copy link
Collaborator

@NGA-TRAN NGA-TRAN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JSOD11 has great comments. I only wonder whether we can also display the plans with the examples

@gabotechs gabotechs merged commit 9509b85 into main Jan 6, 2026
7 checks passed
@gabotechs gabotechs deleted the gabrielmusat/add-custom-execution-plan-example branch January 6, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants