-
Notifications
You must be signed in to change notification settings - Fork 14
Validate TPC-H query results using integration tests #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you @NGA-TRAN ! |
| @@ -0,0 +1,1224 @@ | |||
| use std::fs; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking ahead, once we add more integration tests, I expect we’ll move functions primarily used for TPC-H testing into a dedicated file or module to keep things organized.
|
should we include ignored tests on ci.yml? |
There are a few ignored tests. Can we only include one specific one? I would like to include this test:
|
#11
The TPC-H result validation tests are included in the integration test suite but marked with #[ignore] to prevent them from running during routine cargo test. Once we have a CI pipeline in place, we should make sure these tests are executed as part of it.
q16 is excluded due to this DF bug
Run command:
Output:
Notes:
Just a heads-up—don't read too much into the runtimes here. I’m seeing similar execution times regardless of the number of workers (1, 2, or 3), which suggests there might be overhead in how datafusion-cli handles query execution and result processing. These tests aren’t aimed at benchmarking runtime—they’re primarily for functional validation. I’ll be digging into the performance angle separately.