Add basic Github pipelines #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabotechs
force-pushed
the
add-github-pipelines
branch
from
6242410 to
c481a60
Compare
fmonjalet
approved these changes
Jul 7, 2025
Collaborator
fmonjalet
left a comment
fmonjalet
left a comment
There was a problem hiding this comment.
LGTM at first glance (especially since it is easy to adjust later), but we may want a second look
|
|
||
| - uses: dtolnay/rust-toolchain@stable | ||
| with: | ||
| toolchain: stable |
Collaborator
There was a problem hiding this comment.
Does this always take the latest stable, or will this read what the project requests?
Collaborator
Author
There was a problem hiding this comment.
This will use the latest stable version yes. The project requests a minimum version of 1.82, but I don't think it's enforcing any specific version newer than that
Collaborator
Author
There was a problem hiding this comment.
Do you think it might be better to lock to a specific version?
gabotechs
force-pushed
the
add-github-pipelines
branch
from
c481a60 to
0aaa9a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pipelines will run:
on every: