Refactor QueryPlanner #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiaCastaneda
force-pushed
the
lia/refactor-QueryPlanner
branch
from
869b973 to
5c12df4
Compare
LiaCastaneda
commented
Jul 18, 2025
NGA-TRAN
reviewed
Jul 18, 2025
NGA-TRAN
reviewed
Jul 18, 2025
NGA-TRAN
approved these changes
Jul 18, 2025
Collaborator
NGA-TRAN
left a comment
NGA-TRAN
left a comment
There was a problem hiding this comment.
Very nice @LiaCastaneda 🎉 And Thanks @robtandy for the suggestions.
This refactor lays the groundwork for expanding our unit test coverage and sets up a clear path for introducing integration tests. With these changes, we’re getting close to running TPC-H validation directly—no need to route through Python
LiaCastaneda
force-pushed
the
lia/refactor-QueryPlanner
branch
from
508f77a to
5af6cf5
Compare
robtandy
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
QueryPlannerto avoid distributing tasks inprepare. All the logic for resolving and sending the plan to workers is now handled within thedistribute_planfunction. This decouples the logic and makes it easier to test.Tested the refactor by launching the TPCH cluster and doing
explain,select&describestatements