Add serialization and deserialization tests for all tpc-ch queries #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NGA-TRAN
commented
Jul 18, 2025
|
|
||
| /// Test that we are able to build the physical plan and its version after serialization and deserialization | ||
| #[tokio::test] | ||
| async fn test_serialize_deserialize_tpch_queries() -> Result<()> { |
Collaborator
Author
There was a problem hiding this comment.
This test will fail without recent commit from DF
LiaCastaneda
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
Note: I added small tpc-h parquet files (20 rows each file) to ensure we simulate exact schema. The data will be good for testing correctness that I plan to do next, too