Small cleanup after #74 #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabotechs
commented
Aug 5, 2025
Collaborator
Author
There was a problem hiding this comment.
This file seems to be empty, I just deleted it
Collaborator
Author
There was a problem hiding this comment.
As instead of commenting the tests I have #[ignore]-ed them, this file was still needed, otherwise a compilation error will happen.
Collaborator
Author
There was a problem hiding this comment.
Following the Rust book recommendation https://doc.rust-lang.org/rust-by-example/testing/integration_testing.html, I moved all the common modules that are meant to be used by the integration tests to common/
| #[allow(dead_code)] | ||
| mod common; | ||
| /* | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Instead of having big chunks of commented code, a more Rusty way of handling this is to just #[ignore] the tests
Base automatically changed from
robtandy/port_and_refactor_execution_code
to
main
August 5, 2025 10:58
gabotechs
force-pushed
the
gabrielmusat/port_and_refactor_execution_code_suggestions
branch
from
eef7375 to
e4e2dbb
Compare
robtandy
approved these changes
Aug 6, 2025
gabotechs
deleted the
gabrielmusat/port_and_refactor_execution_code_suggestions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small cleanup after #74: